Bw/overview #160

bogwar · 2025-11-05T11:02:52Z

No description provided.

Co-authored-by: Mathias Björkqvist <[email protected]>

…--> fee_collector

Copilot

Pull Request Overview

This PR adds documentation for ICRC-107 (Fee Management standard) and creates an overview page for Internet Computer standards. The changes include the complete specification for ICRC-107, which standardizes fee collection across ICRC-based ledgers, and a new overview document that categorizes and lists various ICRC standards.

Key changes:

Adds ICRC-107 specification for standardized fee management across ICRC ledgers
Creates a standards overview page to track standard lifecycle status
Introduces new block types and API methods for fee collector configuration

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
ICRCs/overview.md	Overview page listing ICRC standards organized by category with their approval status
ICRCs/ICRC-107/ICRC-107.md	Complete specification for ICRC-107 Fee Management standard including transaction schemas, API methods, and legacy compatibility

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-05T11:04:28Z

ICRCs/overview.md

@@ -0,0 +1,58 @@
+his page provides an up-to-date overview of Internet Computer standards that are nearing completion, actively being developed, or have already been approved by the relevant working groups or the broader community.


Missing 'T' at the beginning of the sentence. Should be 'This page' instead of 'his page'.

Suggested change

his page provides an up-to-date overview of Internet Computer standards that are nearing completion, actively being developed, or have already been approved by the relevant working groups or the broader community.

This page provides an up-to-date overview of Internet Computer standards that are nearing completion, actively being developed, or have already been approved by the relevant working groups or the broader community.

Copilot · 2025-11-05T11:04:29Z

ICRCs/overview.md

+| [ICRC-113](https://github.com/dfinity/wg-token-standards/pull/1) | ICP Network Registry | ![Draft] |
+| ICRC-XX  | Namespacing for `icp` URI scheme | ![Idea] |
+
+### CAIP Compatibility Standards
+
+| Standard | Title                                       | Status     |
+|----------|---------------------------------------------|------------|
+| [CAIP-2-compliant blockchain identifiers](https://github.com/dfinity/wg-token-standards/pull/2) | CAIP-2-compliant blockchain identifiers | ![Draft] |
+| [CAIP-10-compliant account addresses](https://github.com/icvc/icp-namespace/pull/1) | CAIP-10-compliant account addresses | ![Draft] |
+
+### Payment and Other Token-related Standards
+
+| Standard | Title                                       | Status     |
+|----------|---------------------------------------------|------------|
+| [ICRC-22](https://github.com/dfinity/ICRC/pull/101/files) | URI Format for Payment Requests | ![Draft] |
+| [ICRC-91](https://github.com/dfinity/ICRC/pull/96/files) | URI Scheme for Addressing Canister Content via HTTP | ![Draft] |


Inconsistent capitalization in status badges. Lines 43, 44, 50, 51, 57, 58 use '![Draft]' and '![Idea]' with capital D and I, while other status badges like '![STANDARD]', '![APPROVED]', and '![DRAFT]' use all caps. This inconsistency suggests these may be undefined references in the markdown rendering system.

Suggested change

| [ICRC-113](https://github.com/dfinity/wg-token-standards/pull/1) | ICP Network Registry | ![Draft] |

| ICRC-XX | Namespacing for `icp` URI scheme | ![Idea] |

### CAIP Compatibility Standards

| Standard | Title | Status |

|----------|---------------------------------------------|------------|

| [CAIP-2-compliant blockchain identifiers](https://github.com/dfinity/wg-token-standards/pull/2) | CAIP-2-compliant blockchain identifiers | ![Draft] |

| [CAIP-10-compliant account addresses](https://github.com/icvc/icp-namespace/pull/1) | CAIP-10-compliant account addresses | ![Draft] |

### Payment and Other Token-related Standards

| Standard | Title | Status |

|----------|---------------------------------------------|------------|

| [ICRC-22](https://github.com/dfinity/ICRC/pull/101/files) | URI Format for Payment Requests | ![Draft] |

| [ICRC-91](https://github.com/dfinity/ICRC/pull/96/files) | URI Scheme for Addressing Canister Content via HTTP | ![Draft] |

| [ICRC-113](https://github.com/dfinity/wg-token-standards/pull/1) | ICP Network Registry | ![DRAFT] |

| ICRC-XX | Namespacing for `icp` URI scheme | ![IDEA] |

### CAIP Compatibility Standards

| Standard | Title | Status |

|----------|---------------------------------------------|------------|

| [CAIP-2-compliant blockchain identifiers](https://github.com/dfinity/wg-token-standards/pull/2) | CAIP-2-compliant blockchain identifiers | ![DRAFT] |

| [CAIP-10-compliant account addresses](https://github.com/icvc/icp-namespace/pull/1) | CAIP-10-compliant account addresses | ![DRAFT] |

### Payment and Other Token-related Standards

| Standard | Title | Status |

|----------|---------------------------------------------|------------|

| [ICRC-22](https://github.com/dfinity/ICRC/pull/101/files) | URI Format for Payment Requests | ![DRAFT] |

| [ICRC-91](https://github.com/dfinity/ICRC/pull/96/files) | URI Scheme for Addressing Canister Content via HTTP | ![DRAFT] |

Copilot · 2025-11-05T11:04:29Z

ICRCs/ICRC-107/ICRC-107.md

+     - If legacy config designates a collector, credit that account.  
+     - If no legacy collector is configured, burn the fee.
+
+> **Important:** “No block with `btype = "107feecol"` is found is **not** the same as finding one with `tx.feecol = []`.  


Grammatical error with duplicated 'is'. Should be either 'No block with btype = \"107feecol\" found is not' or 'Finding no block with btype = \"107feecol\" is not'.

Suggested change

> **Important:** “No block with `btype = "107feecol"` is found is **not** the same as finding one with `tx.feecol = []`.

> **Important:** No block with `btype = "107feecol"` found is **not** the same as finding one with `tx.feecol = []`.

bogwar and others added 30 commits January 14, 2025 16:26

ICRC-107 initial draft

7dec143

bool -> text for metadata

f45dbed

bool -> text for metadata

63bff20

option 1 from the discussion

b5bae30

new versions

ef25f9e

pass

fc15a30

final draft icrc-107

d2a50c3

deleted old version of icrc107

b24b937

first pass over Thomas' comments

88617a3

implemented WG decisions

d58a821

minor edits

19764d9

minor edits

023326e

eliminated fee_burn

d33d2af

minor changes

199280b

clarified what fee_ops = [] means

86b676a

new summary

e6e4122

included examples, legacy fee collection logic, compliance reporting

4654feb

one more pass

06e6d5d

further clarifications on legacy behaviour

eb7d6a4

typos

d3accbf

typo

12eb7ca

Update ICRCs/ICRC-107/ICRC-107.md

9582f01

Co-authored-by: Mathias Björkqvist <[email protected]>

Update ICRCs/ICRC-107/ICRC-107.md

0944115

Co-authored-by: Mathias Björkqvist <[email protected]>

addressed comments

100b532

rewrite legacy part

597195c

rewrite

1cef2a6

introduced tx structure

1f30ad3

fixed an error type

aeac056

fixed example

92436c8

final(?) pass

b81f013

bogwar added 9 commits September 11, 2025 13:02

alignment with ICRC-3 refinements

dd064ab

clarified the sematnics and aligned wiht ICRC-3

fcd51d3

addressed comments from revies & added clarifications

589b4bd

restructured the semantics section for icrc107_set_fee_collector

34ef399

updated examples

463fdbf

minor typos

b87d0db

icrc107_set_fee_col --> 107set_fee_col in blocks and icrc107_fee_col …

968e4f1

…--> fee_collector

standards overview

9e178d3

initial table/overview

6a44362

bogwar requested a review from Copilot November 5, 2025 11:02

bogwar marked this pull request as draft November 5, 2025 11:03

Copilot AI reviewed Nov 5, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Bw/overview #160

Bw/overview #160

Uh oh!

bogwar commented Nov 5, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Nov 5, 2025

Uh oh!

Copilot AI Nov 5, 2025

Uh oh!

Copilot AI Nov 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

		@@ -0,0 +1,58 @@
		his page provides an up-to-date overview of Internet Computer standards that are nearing completion, actively being developed, or have already been approved by the relevant working groups or the broader community.

	his page provides an up-to-date overview of Internet Computer standards that are nearing completion, actively being developed, or have already been approved by the relevant working groups or the broader community.
	This page provides an up-to-date overview of Internet Computer standards that are nearing completion, actively being developed, or have already been approved by the relevant working groups or the broader community.

	> Important: “No block with `btype = "107feecol"` is found is not the same as finding one with `tx.feecol = []`.
	> Important: No block with `btype = "107feecol"` found is not the same as finding one with `tx.feecol = []`.

Bw/overview #160

Are you sure you want to change the base?

Bw/overview #160

Uh oh!

Conversation

bogwar commented Nov 5, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Nov 5, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 5, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 5, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant